Skip to content

docs: improve dev setup & contributing info #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Jan 20, 2022

Description of your changes

This PR aims at setting a standard development environment and contributing process for this project.

Main takeaways:

  • Node.js 14.x following lts/fermium tag (Active LTS version), support for .nvmrc file
  • Npm 8.x following @next-8 tag
  • Overhauled "Contributing via Pull Requests" section of CONTRIBUTING.md
  • Expanded "Getting Started" section of CONTRIBUTING.md
  • Complemented "Local documentation" section of CONTRIBUTING.md

Shoutout to the amazing AWS CDK Contributing guidelines from which I have liberally borrowed the structure for these changes.

How to verify this change

Check content of CONTRIBUTING.md.

Related issues, RFCs

#422
#426
#115
#485

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added the documentation Improvements or additions to documentation label Jan 20, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 20, 2022
@dreamorosi dreamorosi self-assigned this Jan 20, 2022
@dreamorosi dreamorosi linked an issue Jan 20, 2022 that may be closed by this pull request
Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastico!

chefskiss

@dreamorosi dreamorosi merged commit e5691bb into main Jan 21, 2022
@dreamorosi dreamorosi deleted the docs/development_setup branch January 21, 2022 10:28
@dreamorosi dreamorosi mentioned this pull request Feb 22, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: document lerna commands for local development
3 participants